Unvanquished Development activity

Events from:

Daemon Engine
Daemon Engine
Wednesday, 14 November 2018
@t4im
t4im commented on pull request DaemonEngine/Daemon#140 Nov 14, 2018

Yea, good idea. Using the null-renderer might actually have triggered such a situation.

Daemon Engine
Daemon Engine
Tuesday, 13 November 2018
@slipher
slipher deleted branch slipher/vs2017 at DaemonEngine/Daemon Nov 13, 2018

Updated Nov 13

@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to master
  • @slipher dfebb1d
    Change minimum version (and Appveyor) of Visual Studio to 2017 (#139)
@slipher
slipher commented on pull request DaemonEngine/Daemon#139 Nov 13, 2018

Also I had the PCH on at first, but it didn't work because the NMake generator uses a different directory structure than the Visual Studio one.

@slipher
slipher commented on pull request DaemonEngine/Daemon#140 Nov 13, 2018

I'm not a fan of this change as-is. It relies on all of these functions always populating the buffer with a valid null-terminated string. Maybe set…

@t4im
t4im commented on pull request DaemonEngine/Daemon#139 Nov 13, 2018

Ah, right, didn't see that.

@t4im
t4im opened a pull request in DaemonEngine/Daemon Nov 13, 2018
Fix buffer over-read via std::string::assign copying from buffers past '\0'. #140

The to-be-assigned strings are already providing null-terminated strings, often by means of Q_strncpyz, so std::string::assign(cstring) will correc…

+15 -14
@slipher
slipher commented on pull request DaemonEngine/Daemon#139 Nov 13, 2018

Eh, this flag doesn't even do anything on MSVC.

@t4im
t4im commented on pull request DaemonEngine/Daemon#139 Nov 13, 2018

maybe -DUSE_DEBUG_OPTIMIZE=0 for speed? It's 1 by default, i believe.

@slipher
slipher commented on pull request DaemonEngine/Daemon#139 Nov 13, 2018

I'll squash the commits when merging.

@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
@slipher
slipher pushed to DaemonEngine/Daemon Nov 13, 2018
1 commit to slipher/vs2017
Daemon Engine
Daemon Engine
Monday, 12 November 2018
@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#121 Nov 12, 2018

hmmmmmm, I already reported this issue in #77

@illwieckz
illwieckz closed an issue in DaemonEngine/Daemon Nov 12, 2018
bad translucent texture depth on rsmse map #121

This is an issue similar to #120 (broken water translucency on station15 map) except the translucency is not faulty opaque, only the depth issue is…

2 comments
Unvanquished Assets
Unvanquished Assets
Sunday, 11 November 2018
Unvanquished Assets
Unvanquished Assets
Saturday, 10 November 2018
@illwieckz
illwieckz pushed to UnvanquishedAssets/map-chasm_src.dpkdir Nov 10, 2018
2 commits to travis
@illwieckz
illwieckz pushed to UnvanquishedAssets/map-chasm_src.dpkdir Nov 10, 2018
2 commits to travis
@slipher
slipher opened a pull request in DaemonEngine/Daemon Nov 10, 2018
@slipher
slipher created a branch in DaemonEngine/Daemon Nov 10, 2018
@slipher
slipher pushed to DaemonEngine/Daemon Nov 10, 2018
1 commit to master
  • @slipher 76f27a4
    Write a possibly correct Q_stricmp
@slipher
slipher merged a pull request in DaemonEngine/Daemon Nov 10, 2018
@t4im
t4im commented on issue DaemonEngine/CBSE-Toolchain#29 Nov 10, 2018

Wouldn't the singleton pattern for entities solve this? It would allow to delay EmptyEntity construction until first use and in turn the constructi…

Daemon Engine
Daemon Engine
Thursday, 08 November 2018
@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#48 Nov 8, 2018

@DolceTriade this file looks to be brand new file from you: src/engine/null/null_renderer.cpp (see f854e45) Do you confirm?

@t4im
t4im pushed to DaemonEngine/Daemon Nov 8, 2018
2 commits to master
@t4im
t4im merged a pull request in DaemonEngine/Daemon Nov 8, 2018
Travis/matrix #138

based on feedback by @slipher this skips the osc+gcc build and tries to reduce homebrew install time by using the travis homebrew plugin, hoping th…

+24 -23
@t4im
t4im opened a pull request in DaemonEngine/Daemon Nov 8, 2018
Travis/matrix #138

based on feedback by @slipher this skips the osc+gcc build and tries to reduce homebrew install time by using the travis homebrew plugin, hoping th…

+19 -22
@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

trusty being supported until april 2019 (six months ahead) I guess travis will update to something else (xenial, 16.04, up to april 2021) around th…

@t4im
t4im commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

no, it still uses trusty after

@slipher
slipher commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

Does removing this change anything?

@t4im
t4im pushed to DaemonEngine/Daemon Nov 8, 2018
1 commit to master
  • @t4im 8fbc519
    improve travis build: +ccache, +osx build, -dependencies
@t4im
t4im merged a pull request in DaemonEngine/Daemon Nov 8, 2018
improve travis build: +ccache, +osx build, -dependencies #137

Might remove the engine builds from Unvanquished next so that things only get built in the places they are relevant in.

+49 -16
@t4im
t4im commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

In the apt-get command you don't want any new lines, so no pipe there; it will then be passed to the OS as a single line. I.e. apt-get install some…

@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

ok so the other way to not use pipe would be to put a ; at the end of sudo apt-get -y -q --no-install-recommends install ninja-build and at the end…

@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

that's what my brain inferred, but in this case why is this pipe missing for the first if block in install target?

@t4im
t4im commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

a literal multiline string; so the new lines from the yaml file are preserved Here a great overview of this one and the other 8 types: https://stac…

@Kangz
Kangz commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

IIRC it means it's a multi-line value

@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#137 Nov 8, 2018

I'm almost a totally newb there, what means that pipe?

@t4im
t4im opened a pull request in DaemonEngine/Daemon Nov 8, 2018
improve travis build: +ccache, +osx build, -dependencies #137

Might remove the engine builds from Unvanquished next so that things only get built in the places they are relevant in.

+52 -16
@t4im
t4im commented on pull request Unvanquished/Unvanquished#1096 Nov 8, 2018

We could try to run Daemon headless to run the assertions, similar to how the unit tests would have to be run i suppose. But there is also https://…

@t4im
t4im commented on pull request Unvanquished/Unvanquished#1096 Nov 8, 2018

Ah, well, i was thinking of https://docs.travis-ci.com/user/deployment/releases/ some day; but indeed; right now rather pointless. Debug symbols an…

@slipher
slipher commented on pull request Unvanquished/Unvanquished#1096 Nov 8, 2018

I don't understand the point about the runtime assertions, since no one ever runs the code built on travis. Are you concerned about compile errors …

@t4im
t4im commented on pull request Unvanquished/Unvanquished#1096 Nov 8, 2018

A few other things to consider: software-properties-common appears unused and could be removed? Allowing the mac build to fail with fast-finish mi…

@t4im
t4im opened a pull request in Unvanquished/Unvanquished Nov 8, 2018
use ccache with travis #1096

Might not store changes from PRs, and as such might not be visible until after a few changes to master. But if it works, it could potentially speed…

+2 -0
@t4im
t4im pushed to Unvanquished/Unvanquished Nov 8, 2018
1 commit to master
  • @t4im dda9cc2
    update cbse and daemon submodules
Unvanquished
Unvanquished
Wednesday, 07 November 2018
@t4im
t4im pushed to Unvanquished/Unvanquished Nov 7, 2018
2 commits to master
@t4im
t4im merged a pull request in Unvanquished/Unvanquished Nov 7, 2018
some cbse related cleanups #1094

Foremost it removes/replaces several CBSE.h includes so that changes to entities or component headers won't result in a full rebuild anymore. There…

+371 -327
2 comments
@t4im
t4im pushed to DaemonEngine/Daemon Nov 7, 2018
1 commit to master
  • @t4im 9613b69
    Add CBSE-templates to cmake DEPENDS, to force regeneration on templat…
@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#136 Nov 7, 2018

it looks like original file used space-based spacing™ (I don't know why but all the cmake files I've seen use spaces even if tabs work)

@Viech
Viech commented on pull request DaemonEngine/Daemon#135 Nov 7, 2018

Do you know the measured aggression™ approach to code testing? Only write new tests for as long as the number of open issues brought to light is bo…

@slipher
slipher commented on pull request DaemonEngine/Daemon#135 Nov 7, 2018

Thanks for checking! It is unfortunate that dark forces conspire to prevent our codebase from having any tests.