Unvanquished Development activity

Events from:

Unvanquished Assets
Unvanquished Assets
Wednesday, 25 April 2018
@slipher
slipher commented on pull request UnvanquishedAssets/unvanquished_src.dpkdir#4 Apr 25, 2018

Binding Escape has no effect, it is ignored (this was true before my changes as well).

Unvanquished Assets
Unvanquished Assets
Tuesday, 24 April 2018
@illwieckz
illwieckz commented on pull request UnvanquishedAssets/unvanquished_src.dpkdir#4 Apr 24, 2018

is togglemenu keybind not needed anymore?

@slipher
slipher commented on pull request Unvanquished/Unvanquished#1073 Apr 24, 2018

Actually, I just thought of one bind that would be broken by this: +movedown is also needed for spectators.

@slipher
slipher opened a pull request in Unvanquished/Unvanquished Apr 24, 2018
Remove default-team binds when changing keys in the bind menu #1073

When you change a bind using the menu, any old keys with the command are removed. But the removal does not succeed if the existing bind is for the …

+12 -3
Unvanquished Assets
Unvanquished Assets
Monday, 23 April 2018
@illwieckz
illwieckz opened a pull request in UnvanquishedAssets/map-chasm_src.dpkdir Apr 23, 2018
add snowflakes particles in the outdoor place right to human base #1

There was no snowflake particle in that place, now there is:

+10 -0
Unvanquished
Unvanquished
Sunday, 22 April 2018
@illwieckz
illwieckz opened an issue in Unvanquished/Unvanquished Apr 22, 2018
noclip spectator is acting like a thirdperson view with third-person camera clipped on walls #1072

noclip spectator is acting like a thirdperson view with third-person camera clipped on walls

@illwieckz
illwieckz pushed to for-0.51.0 in Unvanquished/Unvanquished Apr 22, 2018
@illwieckz
illwieckz merged a pull request in Unvanquished/Unvanquished Apr 22, 2018
Remove the repeater. #1062

The model will be reused for the drill. It's not a very useful structure now that humans no longer require power to build.

+35 -104
12 comments
@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1062 Apr 22, 2018

I don't see anything that is missing at this point, good job.

@illwieckz
illwieckz pushed to for-0.51.0 in Unvanquished/Unvanquished Apr 22, 2018
@illwieckz
illwieckz merged a pull request in Unvanquished/Unvanquished Apr 22, 2018
enable cg_bounceParticles by default #1070

it's 2018 man! it does not mean #719 does not have to be fixed but having particle bouncing by default looks to be the player's expected in-game ex…

+1 -1
@slipher
slipher opened an issue in Unvanquished/Unvanquished Apr 22, 2018
Include the engine PCH? #1071

On a review a while ago @Kangz suggested that headers in Daemon are not supposed to have to include anything that is already included by the precom…

Unvanquished
Unvanquished
Saturday, 21 April 2018
@illwieckz
illwieckz opened a pull request in Unvanquished/Unvanquished Apr 21, 2018
enable cg_bounceParticles by default #1070

it's 2018 man! it does not mean #719 does not have to be fixed but having particle bouncing by default looks to be the player's expected in-game ex…

+1 -1
@slipher
slipher commented on issue Unvanquished/Unvanquished#1068 Apr 21, 2018

I think it can be useful in cases where an intentionally not translated string can be mistaken for an oversight. I don't suggest apply it to all no…

@Viech
Viech commented on issue Unvanquished/Unvanquished#1059 Apr 21, 2018

As long as they bounce if they are allowed to by cgame, no. Note that bouncing and colliding are probably interchangable terms here as the collisio…

@Viech
Viech commented on pull request DaemonEngine/Daemon#100 Apr 21, 2018

@illwieckz is further known for making a pull request before extending the vacuum cleaner cable. 🙃

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1062 Apr 21, 2018

I just added a commit to edit comments like @slipher asked for. @DolceTriade if you have nothing to add can we merge that?

@illwieckz
illwieckz pushed to for-0.51.0 in Unvanquished/Unvanquished Apr 21, 2018
@illwieckz
illwieckz merged a pull request in Unvanquished/Unvanquished Apr 21, 2018
Merge keyboard handling changes #1069

This was already done on engine side: DaemonEngine/Daemon#91 so we need this on game side too. note that: Developers should be aware that if you u…

+206 -184
@illwieckz
illwieckz commented on issue Unvanquished/Unvanquished#1059 Apr 21, 2018

So this is issue is not an issue, right?

@Viech
Viech commented on issue Unvanquished/Unvanquished#1059 Apr 21, 2018

It should be. Buildable remains are just particles after all.

@illwieckz
illwieckz opened a pull request in Unvanquished/Unvanquished Apr 21, 2018
Merge keyboard handling changes #1069

This was already done on engine side: DaemonEngine/Daemon#91 so we need this on game side too. note that: Developers should be aware that if you u…

+206 -184
@illwieckz
illwieckz pushed to for-0.51.0 in DaemonEngine/Daemon Apr 21, 2018
@illwieckz
illwieckz merged a pull request in DaemonEngine/Daemon Apr 21, 2018
merge master into for-0.51.0 #100

merge master into for-0.51.0

+45 -31
@illwieckz
illwieckz opened a pull request in DaemonEngine/Daemon Apr 21, 2018
merge master into for-0.51.0 #100

merge master into for-0.51.0

+45 -31
@illwieckz
illwieckz pushed to for-0.51.0 in DaemonEngine/Daemon Apr 21, 2018
@illwieckz
illwieckz merged a pull request in DaemonEngine/Daemon Apr 21, 2018
pass DAEMON_DIR back to nacl vm build #98

for some reason some nacl vm related build steps are driven by the engine cmake configuration, hence when the engine is not built as a submodule, t…

+1 -0
1 comment
@slipher
slipher commented on pull request DaemonEngine/Daemon#98 Apr 21, 2018

It's a bit odd that DAEMON_DIR is referenced here when it is an option defined in the Unvanquished project, but I'd say go ahead with this since it…

@slipher
slipher closed an issue in DaemonEngine/Daemon Apr 21, 2018
crash once station15 map is loaded #94

Running Dæmon's current for-0.51.0 branch and Unvanquiqhed's riprepeater branch (from Unvanquished/Unvanquished#1062) and latest packages I get a c…

10 comments
@slipher
slipher pushed to master in DaemonEngine/Daemon Apr 21, 2018
@slipher
slipher merged a pull request in DaemonEngine/Daemon Apr 21, 2018
Fix crash from #94. #97

Also an unhandled exception in the "math" command.

+45 -31
1 comment
@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#97 Apr 21, 2018

I confirm it fixes the crash, thank you! :-)

@illwieckz
illwieckz opened an issue in DaemonEngine/Daemon Apr 21, 2018
engine is looking for irt_core-x86_64.nexe nacl_helper_bootstrap and nacl_loader in libpath #99

I noticed that the engine build system is building irt_core-x86_64.nexe, nacl_helper_bootstrap and nacl_loader in engine's build path, but the engi…

@illwieckz
illwieckz opened a pull request in DaemonEngine/Daemon Apr 21, 2018
pass DAEMON_DIR back to nacl vm build #98

for some reason some nacl vm related build steps are driven by the engine cmake configuration, hence when the engine is not built as a submodule, t…

+1 -0
@slipher
slipher commented on issue DaemonEngine/Daemon#94 Apr 21, 2018

Turns out that there was one thing wrong with it (cm.leafbrushes was not allocated yet) but it was easy to switch the order. #97

@slipher
slipher opened a pull request in DaemonEngine/Daemon Apr 21, 2018
Fix crash from #94. #97

Also an unhandled exception in the "math" command.

+45 -31
Unvanquished
Unvanquished
Friday, 20 April 2018
@illwieckz
illwieckz commented on issue Unvanquished/Unvanquished#1059 Apr 20, 2018

Enabling "Allow particles to bounce off surfaces" option (cg_bounceParticles set to 1) fixes the issue. Is the described behavior the correct one w…

@DolceTriade
DolceTriade commented on issue DaemonEngine/Daemon#94 Apr 20, 2018

There is nothing wrong with that. It's the preferred approach imo. Changing to int64 just has fewer lines of code modified :p

@slipher
slipher commented on issue DaemonEngine/Daemon#94 Apr 20, 2018

What's wrong with my suggestion of having a pointer instead of firstLeafBrush? Then it's less sketchy and you simply replace cm.leafbrushes[leaf->f…

@DolceTriade
DolceTriade commented on issue DaemonEngine/Daemon#94 Apr 20, 2018

We root caused this bug as a result of our change from allocating CM stuff in the hunk to allocating it using malloc. Daemon/src/common/cm/cm_lo…

@DolceTriade
DolceTriade closed a pull request in DaemonEngine/Daemon Apr 20, 2018
cm: Properly initialize box_model #96

If we don't initialize it, it holds garbage values for some of the fields which cause crashes when accessed. Fixes #94

+1 -1
5 comments
@DolceTriade
DolceTriade commented on pull request DaemonEngine/Daemon#96 Apr 20, 2018

No, silpher is correct. This commit does nothing. Turns out I was hasty and this bug doesn't occur 100% of the time.

@Viech
Viech commented on pull request DaemonEngine/Daemon#96 Apr 20, 2018

Could this not depend on the compiler and optimization level?

@Viech
Viech commented on issue Unvanquished/Unvanquished#719 Apr 20, 2018

I can imagine the particles spawning in or above the skybox brushes, and with bounces they would find their way while otherwise they would just des…

@Viech
Viech commented on issue Unvanquished/Unvanquished#1068 Apr 20, 2018

Is a marker for intentionally not translated really necessary? A string literal without any function applied to it already does the trick.

Unvanquished
Unvanquished
Thursday, 19 April 2018
@illwieckz
illwieckz commented on issue Unvanquished/Unvanquished#719 Apr 19, 2018

The bug occurs when "Allow particles to bounce off surfaces" option is not activated (cg_bounceParticles set to 0 which is the default).

@slipher
slipher pushed to for-0.51.0 in DaemonEngine/Daemon Apr 19, 2018
@slipher
slipher merged a pull request in DaemonEngine/Daemon Apr 19, 2018
Daemon Engine
Daemon Engine
Wednesday, 18 April 2018
@slipher
slipher commented on pull request DaemonEngine/Daemon#96 Apr 18, 2018

This commit is a no-op. Global variables are default-initialized (to all 0 for a simple struct) by default.

@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#96 Apr 18, 2018

bad news, it's not enough to fix the bug on my end. 😕

@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#96 Apr 18, 2018

Thanks! I'll try it when I'm at home!

@slipher
slipher opened an issue in Unvanquished/Unvanquished Apr 18, 2018
N_ translation marker confusion #1068

The N_ translation tag is intended to be used for strings where the translation is deferred, i.e. the translation is performed in a different code …

@DolceTriade
DolceTriade opened a pull request in DaemonEngine/Daemon Apr 18, 2018
cm: Properly initialize box_model #96

If we don't initialize it, it holds garbage values for some of the fields which cause crashes when accessed. Fixes #94

+1 -1
@slipher
slipher commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

p1 certainly looks like a garbage value.

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

I configured with -D'CMAKE_BUILD_TYPE=Debug' -D'USE_DEBUG_OPTIMIZE=OFF', rebuilt, then: Thread 26 "daemon" received signal SIGSEGV, Segmentation fa…

@slipher
slipher commented on pull request DaemonEngine/Daemon#95 Apr 18, 2018

In cases (such as this one) where the string is going to eventually be stored somewhere,, it can be more efficient to pass by value since if you ha…

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

if I do: int p1 = leaf->firstLeafSurface; int p2 = cm.leafsurfaces[ p1 + k ]; printf("p2: %d\n", p2); surface = cm.surfaces[ p2 ]; I get: p2: 13360

@Kangz
Kangz commented on pull request DaemonEngine/Daemon#95 Apr 18, 2018

It was before StringRef and std::moved inside I guess?

@DolceTriade
DolceTriade commented on pull request DaemonEngine/Daemon#95 Apr 18, 2018

I wonder why these aren't passed by reference or Str::StringRefs.

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

If instead of doing: surface = cm.surfaces[ cm.leafsurfaces[ leaf->firstLeafSurface + k ] ]; I do: int p1 = leaf->firstLeafSurface; int p2 = cm.l…

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

Well, I just had to build with -DUSE_BREAKPAD=OFF to be able to backtrace the solib… Perhaps we must never use breakpad to build the solib even if …

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#94 Apr 18, 2018

The crash was first discovered and reproduced using solib cgame. I'm not able to reproduce the bug while running native cgame exe on gdb (-set vm.c…

Unvanquished
Unvanquished
Tuesday, 17 April 2018
@illwieckz
illwieckz closed an issue in Unvanquished/Unvanquished Apr 17, 2018
how is that possible the engine looks for “level3.iqm:pain2” file name? #1044

I don't know if it's an engine, gamecode or asset issue, but: Debug: Failed to open 'models/players/level3/level3.iqm:die2' for reading: Filename c…

3 comments
@illwieckz
Use current repeater model for the drill. #2

It looks better and more fitting, and the repeater is not part of the game anymore. The current drill model should be kept somewhere safe, though.

2 comments
Daemon Engine
Daemon Engine
Sunday, 15 April 2018
@slipher
slipher opened a pull request in DaemonEngine/Daemon Apr 15, 2018
Daemon Engine
Daemon Engine
Saturday, 14 April 2018
@slipher
slipher deleted branch keys_revamp at DaemonEngine/Daemon Apr 14, 2018
@slipher
slipher pushed to for-0.51.0 in DaemonEngine/Daemon Apr 14, 2018
@slipher
slipher merged a pull request in DaemonEngine/Daemon Apr 14, 2018
Merge keyboard handling changes #91

Developers should be aware that if you use the new keyboard code and then subsequently use an older version again, it will wipe out the key binding…

+2,296 -2,343
@slipher
slipher pushed to keys_revamp in DaemonEngine/Daemon Apr 14, 2018
  • @slipher 270336f
    Remove the bizarre, and now unused, Q_UTF8_(Un)Store functions.
Daemon Engine
Daemon Engine
Thursday, 12 April 2018
@illwieckz
illwieckz opened an issue in DaemonEngine/Daemon Apr 12, 2018
crash while station15 map is loaded #94

Running Dæmon's current for-0.51.0 branch and Unvanquiqhed's riprepeater branch (from Unvanquished/Unvanquished#1062) and latest packages I get a c…

@slipher
slipher commented on issue Unvanquished/Unvanquished#536 Apr 12, 2018

True spectator binds that aren't the same as default binds are implemented for 0.51.

@slipher
slipher commented on issue Unvanquished/Unvanquished#544 Apr 12, 2018

We now have the capability to make binds based on the physical key position, so it is no longer necessary to worry about restricting the default bi…

Daemon Engine
Daemon Engine
Wednesday, 11 April 2018
@illwieckz
illwieckz closed an issue in DaemonEngine/Daemon Apr 11, 2018
weird patterns on translucent textures #68

This bug affects the for-0.51.0 branch, I cannot reproduce with a 0.50.0 build and I haven't tried master. Look at these screenshots of the hangar28

11 comments
@slipher
slipher closed an issue in DaemonEngine/Daemon Apr 11, 2018
Error compiling Crypto.cpp: invalid conversion from ‘unsigned char*’ to ‘char*’ #58

On Arch Linux 4.13.12 using gcc-multilib 7.2.0: …/daemon/src/engine/framework/Crypto.cpp: In function ‘Crypto::Data Crypto::Encoding::Base64Encode(…

1 comment
@zorun
zorun commented on issue Unvanquished/Unvanquished#1020 Apr 11, 2018

It's been exactly 2 years today since the release of 0.50 Any plans for the 0.51 release soon? :)

@illwieckz
illwieckz pushed to for-0.51.0 in DaemonEngine/Daemon Apr 10, 2018
@illwieckz
illwieckz merged a pull request in DaemonEngine/Daemon Apr 10, 2018
merge master to for-0.51.0 #93

merge master to for-0.51.0

+98 -10
@illwieckz
illwieckz opened a pull request in DaemonEngine/Daemon Apr 10, 2018
merge master to for-0.51.0 #93

merge master to for-0.51.0

+98 -10
@slipher
slipher pushed to keys_revamp in Unvanquished/Unvanquished Apr 10, 2018
@slipher
slipher merged a pull request in Unvanquished/Unvanquished Apr 10, 2018
Refresh keys in key binding UI #1067

This is mostly interesting if the user changes keyboard layout. Then the binds will be the same, but they will be displayed as different characters.

+15 -13
Unvanquished
Unvanquished
Monday, 09 April 2018
@slipher
slipher opened a pull request in Unvanquished/Unvanquished Apr 9, 2018
Refresh keys in key binding UI #1067

This is mostly interesting if the user changes keyboard layout. Then the binds will be the same, but they will be displayed as different characters.

+15 -13
@slipher
slipher pushed to keys_revamp in Unvanquished/Unvanquished Apr 9, 2018
@slipher
slipher merged a pull request in Unvanquished/Unvanquished Apr 9, 2018
Use new key binding system in cgame. #1065

See DaemonEngine/Daemon#75 for the engine side. TODO: Fix license headers of added file.

+194 -174
1 comment
Daemon Engine
Daemon Engine
Sunday, 08 April 2018
@illwieckz
illwieckz commented on pull request DaemonEngine/Daemon#48 Apr 8, 2018
@DolceTriade
DolceTriade pushed to riprepeater in Unvanquished/Unvanquished Apr 8, 2018
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds Apr 8, 2018
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds Apr 8, 2018
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds Apr 8, 2018
@slipher
slipher pushed to for-0.51.0 in DaemonEngine/Daemon Apr 8, 2018
  • @slipher 9e42f6d
    Import warning fixes for crn_decomp.h from crunch repo.
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds Apr 8, 2018
@slipher
slipher deleted branch slipher/unity-warnings at DaemonEngine/crunch Apr 8, 2018
@slipher
slipher merged a pull request in DaemonEngine/crunch Apr 8, 2018